Skip to content

feat: enable Prisma Next completion parameter hints - #2003

Merged
SevInf merged 3 commits into
mainfrom
signature-help-client-opt-in
Sep 16, 2026
Merged

SevInf merged 3 commits into
mainfrom
signature-help-client-opt-in

Conversation

@StevenMcClankerton

@StevenMcClankerton StevenMcClankerton commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Enables completion-triggered parameter hints for the Prisma Next VS Code client via the existing built-in command. No custom commands, keybindings, or Tab/Shift+Tab interception. Legacy clients unchanged.

Companion to prisma/orm#30312; requires that server support.

Verification: language-server build, extension/test typechecks and targeted lint/format checks passed before removing the redundant test. Editor UI behavior has not been manually verified.

Signed-off-by: Steven McClankerton <tatarintsev+clanker@prisma.io>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 07cc3757-e6d0-4ad8-8703-deb85e004cb4

📥 Commits

Reviewing files that changed from the base of the PR and between d09fbab and 3579a1d.

📒 Files selected for processing (3)
  • docs/language-server.md
  • packages/vscode/src/__test__/language-server/prismaNextClientOptions.test.ts
  • packages/vscode/src/plugins/prisma-language-server/prismaNextClients.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Summary by CodeRabbit

  • New Features

    • Prisma Next completions can now trigger parameter hints after a completion is accepted, when supported by the language server and compatible editor.
  • Documentation

    • Added documentation describing completion-triggered parameter hint support and its compatibility requirements.
  • Tests

    • Added coverage verifying that Prisma Next advertises support for triggering parameter hints.

Walkthrough

The Prisma Next client now sends initializationOptions.completion.supportsTriggerParameterHintsCommand: true to the language server. A test verifies this option. Documentation describes the capability and its dependency on server support. The legacy client remains unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 74c4c

The PR adds an opt-in capability advertisement with matching focused coverage and documentation; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling Prisma Next completion parameter hints.
Description check ✅ Passed The description accurately explains the completion-triggered parameter hints, implementation scope, server dependency, legacy-client impact, and verification status.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch signature-help-client-opt-in
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch signature-help-client-opt-in

Comment @coderabbitai help to get the list of available commands.

Comment thread docs/language-server.md Outdated
Signed-off-by: Steven McClankerton <tatarintsev+clanker@prisma.io>
Signed-off-by: Steven McClankerton <tatarintsev+clanker@prisma.io>
@SevInf SevInf added this to the 8.0.0 milestone Sep 16, 2026
@SevInf
SevInf merged commit aa6c95d into main Sep 16, 2026
10 of 11 checks passed
@SevInf
SevInf deleted the signature-help-client-opt-in branch September 16, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants