Repository navigation
Phase 4: workout detail (edit/delete past workouts) and History month calendar - #20
Merged
Merged
Conversation
Tapping a workout in History opens its detail: date, duration, sets and volume, the records it set, its notes, and each exercise's done sets with PR badges. Edit switches to the logger's own editor (keypad, set types, add/remove/reorder exercises, notes) with "Last" taken from the session before this one; Delete asks first. Every edit recomputes the exercise's records from its whole history, as in the logger. The logger's editing logic moves into SessionEditor, shared by both screens. A set ticked in a finished workout is stamped with the workout's end rather than now, so records it sets are dated to that session. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GHaDc9HDRJE9PD2G3
History gets a List / Calendar switch. The calendar shows a month in the locale's week order, with days that have a finished workout filled in and today ringed; arrows move between months up to the current one. Below it, the month's workouts are listed with their totals, and tapping a trained day narrows the list to that day. The cards open the workout detail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GHaDc9HDRJE9PD2G3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes Phase 4 with its last two checklist items, one commit each.
Workout detail screen; edit or delete a past workout
history/{workoutId}: date, duration · sets · volume, the records the workout set, its notes, and each exercise's done sets with PR badges (plus "N sets not done" where some were left unticked).getSetsBeforequery), and rest times are hidden. Edits save as they're made and recompute that exercise's records from its whole history, as the logger already does.completedAt= the workout's end instead of now, so any record it sets is dated to that session.WorkoutViewModelintoSessionEditor, shared by both screens;ActiveContentis split into a reusableSessionEditorContentwith header/footer slots. No behaviour change intended in the logger.Month calendar with trained days highlighted
Not included
Testing
./gradlew testDebugUnitTest ktlintCheck lintDebug assembleDebugpasses locally (193 unit tests; lint has no new warnings).setsBefore,observeWorkoutafter delete,doneExercises, and the calendar grid / by-day grouping / month bounds.Generated by Claude Code