Repository navigation
Dark-mode trophy fix, and the design pass (D1–D5) in the plan - #21
Merged
Merged
Conversation
The trophy on the PR card (finish summary and workout detail) used tertiary while its text used onTertiaryContainer. Some dynamic dark schemes give tertiaryContainer a light tone, so a light trophy almost vanished on it. It now uses onTertiaryContainer, like the text beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GANPAD3Wh4VJegyot
Adds five phases between Phase 4 and Phase 5 for the picked design review findings, with the decisions that keep them consistent and the ones still open. Phase 5 picks up the Settings structure, empty states and an accessibility check; v1.2 and v1.3 note what D4 already covers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GANPAD3Wh4VJegyot
Settles the rep range control, routine row tap, tab title style, drag-to-reorder and font choices; keeps the shared rest/elapsed chip open with its swipe-to-peek direction; fixes the charts milestone in the stack table to v1.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GANPAD3Wh4VJegyot
Closes the last open design decision: the top-bar chip shows the rest countdown during rest, and tapping the routine title flips it to the elapsed time for 5 seconds. Adds a Resume workout button on the finish summary in D2, since the new top bar puts Finish beside the chip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GANPAD3Wh4VJegyot
The milestones were only ever ticked off here, so the working agreement now names this file as the tracker and drops milestones and issues. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5GANPAD3Wh4VJegyot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trophy fix
The trophy on the records card (finish summary and workout detail) was tinted
tertiary, while the text beside it usedonTertiaryContainer. Some dynamic dark schemes givetertiaryContainera light tone, so the light trophy almost vanished. It now usesonTertiaryContainer, like its text. One line inui/workout/WorkoutScreen.kt.Plan
docs/IMPLEMENTATION_PLAN.mdgains a design pass from the UI review picks, between Phase 4 and Phase 5:It also records the design decisions settled along the way. Phase 5 picks up the Settings structure, empty states and an accessibility check. The Stack table's charts entry now says v1.2, and the working agreement drops GitHub milestones and issues: the plan file is the only tracker.
Checks
./gradlew testDebugUnitTest ktlintCheck lintDebug assembleDebugpasses locally.Generated by Claude Code