Repository navigation
Phase D2: aligned set table, gold PR disc, keypad context line, RPE opt-in (schema v3) - #23
Merged
Merged
Conversation
…tter) - Full light and dark colour schemes from #2E6B30 with every role set, surface containers included; dynamic colour is now off by default. - Record gold as an extended colour family (MaterialTheme.recordColors) beside the scheme; the logger's PR badge, History cards, exercise detail trophies and the finish summary's records card move off tertiary. - One formatter in ui/format: live timers keep the clock format, finished durations read "58 min" / "1 h 11 min", and every displayed weight and volume goes through it with its unit. - Tabular figures for timers, set fields, the Last column and totals. - Shared RecordChip, RecordDisc and StatTile components; History cards use the chip for their PR count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5DHYQ5GxporYx5N4XW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5DHYQ5GxporYx5N4XW
- Set fields are filled and borderless until the keypad is on them; done
rows get a light primary tint, and the done tick is a filled square
(empty outlined box when not done) with a 48 dp touch target.
- A set holding records shows its label on a gold disc in place of the
PR badge, read out as "Set 1, personal record: heaviest weight".
- The keypad has a context line ("Bench Press · Set 3 · Reps", last
time on the right) holding the hide button; step keys show their unit
("+2.5 kg", "+1 rep") and Next spans two keys.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014thT5DHYQ5GxporYx5N4XW
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014thT5DHYQ5GxporYx5N4XW
- The set table follows the chosen "aligned table" design: one column
grid shared by small-caps headings and rows, 56 dp rows edge to edge,
filled wells only on sets not yet done, a full-width tint on done rows,
and the exercise card as a raised, outlined surface with its targets
(or muscle and equipment) under the name.
- RPE is opt-in per library exercise from its menu ("Show RPE column"),
and still shows when any of its sets has RPE. The number columns narrow
to make room.
- Schema v3 adds exercises.tracksRpe (default off), with MIGRATION_2_3,
a migration test, and DAO and repository tests.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014thT5DHYQ5GxporYx5N4XW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first slice of Phase D2 (workout logger). The set table follows design "A · Aligned table", picked from four mock-ups. The top bar, rest chip and peek, and Resume workout follow in separate PRs.
What changed
exercises.tracksRpe(default off), with "Show RPE column" / "Hide RPE column" in each exercise's ⋮ menu. It's stored on the library exercise, so it carries into later workouts.MIGRATION_2_3, the exported3.json, a migration test (rows kept, RPE off), and DAO and repository tests.RecordDisc. TalkBack reads "Set 1, personal record: heaviest weight", with "Set options" as its click action.ColorScheme.isDarkpicks the card and well surfaces: lowest/container in light, container/high in dark.Testing
./gradlew testDebugUnitTest ktlintCheck lintDebug assembleDebugpasses locally, including the newKeypadContextTest, the 2 → 3 migration test, and the DAO and repository tests fortracksRpe.Branch note
This branch previously carried the D1 commits, which #22 squash-merged. An
oursmerge records that old history without changing any files, so the diff againstmainis only the D2 work.🤖 Generated with Claude Code
https://claude.ai/code/session_014thT5DHYQ5GxporYx5N4XW