Bump backend and cli submodules to include fix for #1062 - #1066
Merged
rquidute merged 2 commits intoJul 22, 2026
Conversation
Pulls in the merged fixes for the WebSocket disconnect that occurred during large manual log file uploads (e.g. TC-CADMIN-1.17): - backend f49b828..cb44885: batches uploaded log lines into chunks before logging (instead of one logger.info() call per line, which stalled the event loop long enough to trip the WebSocket's keepalive), and raises the production ws_ping_timeout to 60s (certification-tool-backend#343). - cli 79cb747..0f00720: stops misreporting a successful upload as "Unexpected error uploading file" when the confirmation send fails after the file was already uploaded, and strips stray whitespace/CR from the uploaded file path prompt input (certification-tool-cli#105).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
antonio-amjr
approved these changes
Jul 22, 2026
oxesoft
pushed a commit
that referenced
this pull request
Aug 20, 2026
* Bump backend and cli submodules to include fix for #1062 Pulls in the merged fixes for the WebSocket disconnect that occurred during large manual log file uploads (e.g. TC-CADMIN-1.17): - backend f49b828..cb44885: batches uploaded log lines into chunks before logging (instead of one logger.info() call per line, which stalled the event loop long enough to trip the WebSocket's keepalive), and raises the production ws_ping_timeout to 60s (certification-tool-backend#343). - cli 79cb747..0f00720: stops misreporting a successful upload as "Unexpected error uploading file" when the confirmation send fails after the file was already uploaded, and strips stray whitespace/CR from the uploaded file path prompt input (certification-tool-cli#105). * Update docker-compose.yml backend image tag to cb44885 to match submodule # Conflicts: # backend # cli # docker-compose.yml
Contributor
|
Cherry-picked to v2.16-beta2+summer2026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
backendandclisubmodules to include the merged fixes for #1062 (THCLI reports a WebSocket error after successfully uploading a manual test log, e.g. TC-CADMIN-1.17).Submodule changes
f49b828..cb44885— certification-tool-backend#343: batches uploaded log lines into chunks of 500 before logging (instead of onelogger.info()call per line, which stalled the event loop long enough to trip the WebSocket's keepalive ping/pong), and raises the productionws_ping_timeoutto 60s to match the existing dev-only setting.79cb747..0f00720— certification-tool-cli#105: stops misreporting a successful upload as❌ Unexpected error uploading filewhen sending the confirmation fails after the file was already uploaded, and strips stray whitespace/CR from the uploaded file path prompt input (a separate bug found while verifying this fix, where a trailing\rfrom some terminals caused a valid, existing file path to be rejected).Note: the cli bump also pulls in an unrelated, already-merged commit (
79cb747..0f00720includes PR #103, a Push AV Stream Verification fix) since it was merged intov2.15.1-cli-developbetween when this work started and now.Testing
Both submodule PRs were reviewed, had review feedback addressed, and merged individually with unit test coverage. This PR is a pointer-only change (no other file modifications).