Skip to content

[Feature] Removing hardcoded prompt timeout - #801

Merged
antonio-amjr merged 1 commit into
project-chip:mainfrom
antonio-amjr:feature/configurable_timeout
Aug 26, 2026
Merged

[Feature] Removing hardcoded prompt timeout#801
antonio-amjr merged 1 commit into
project-chip:mainfrom
antonio-amjr:feature/configurable_timeout

Conversation

@antonio-amjr

@antonio-amjr antonio-amjr commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Fix: project-chip/certification-tool#1038
Related to: project-chip/certification-tool-backend#356

Description

Removes the redundant timeout=60 / PROMPT_TIMEOUT overrides in the onboarding QR/manual-pairing-code prompts. These duplicated the PromptRequest default with no distinct intent, so they now inherit the new project-configurable prompt timeout
from certification-tool-backend (see that PR).

Changed

  • onboarding_script_support.py: dropped PROMPT_TIMEOUT = 60 constant and its use.
  • tcdd12/tcdd12.py, tcdd14/tcdd14.py: dropped explicit timeout=60 kwargs.

Test plan

  • No behavior change when the owning project has no th_config — same 60s default.
  • Covered indirectly by backend's test_python_test_case.py / prompt-support tests.

@antonio-amjr antonio-amjr self-assigned this Aug 21, 2026
@antonio-amjr antonio-amjr added the enhancement New feature or request label Aug 21, 2026
@antonio-amjr antonio-amjr changed the title Removing hardcoded prompt timeout [Feature] Removing hardcoded prompt timeout Aug 21, 2026
@mergify

mergify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@antonio-amjr
antonio-amjr removed the request for review from raju-apple August 26, 2026 12:24
@antonio-amjr
antonio-amjr merged commit 0a114b2 into project-chip:main Aug 26, 2026
3 checks passed
@antonio-amjr
antonio-amjr deleted the feature/configurable_timeout branch August 26, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable timeout for user prompts (currently hardcoded to 60 seconds)

3 participants