Skip to content

feat(alibaba): add slb, alb, eip and ack - #784

Merged
Mzack9999 merged 4 commits into
devfrom
feat/775-alibaba-slb-eip-ack
Oct 8, 2026
Merged

Mzack9999 merged 4 commits into
devfrom
feat/775-alibaba-slb-eip-ack

Conversation

@dogancanbakir

@dogancanbakir dogancanbakir commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Fixes #775

New services slb, alb, eip, ack in the configured region, paginated, over HTTPS. Documents the RAM policies in PROVIDERS.md.

Tested against a fake API server with the real SDK client; no live account.

Summary by CodeRabbit

  • New Features
    • Alibaba Cloud resource discovery now supports Classic Load Balancers, Application Load Balancers, Elastic IPs, and Kubernetes clusters, alongside existing instances.
    • Discovered resources include relevant public and private IP addresses, DNS names, and cluster API endpoints.
  • Documentation
    • Updated Alibaba Cloud documentation with supported services and the corresponding read-only access policies.

@dogancanbakir dogancanbakir self-assigned this Oct 8, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d7950b98-e14f-4dfd-ae72-80035342463e
📥 Commits

Reviewing files that changed from the base of the PR and between 067cfbc and 6b5c958.

📒 Files selected for processing (7)
  • PROVIDERS.md
  • pkg/providers/alibaba/ack.go
  • pkg/providers/alibaba/alb.go
  • pkg/providers/alibaba/alibaba.go
  • pkg/providers/alibaba/alibaba_test.go
  • pkg/providers/alibaba/eip.go
  • pkg/providers/alibaba/slb.go

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Walkthrough

Alibaba Cloud provider support now includes SLB, ALB, EIP, and ACK alongside instances. Selected services receive clients, and the provider aggregates resources from enabled services. The new providers map load balancer addresses, Elastic IPs, and ACK API-server endpoints into resource records.

Changes

Alibaba Cloud service expansion

Layer / File(s) Summary
Service client setup and dispatch
pkg/providers/alibaba/alibaba.go
Selected services receive SDK clients. Resources invokes providers for non-nil clients, merges returned resources, and uses a general Alibaba listing error message.
Resource listing for new services
pkg/providers/alibaba/slb.go, pkg/providers/alibaba/alb.go, pkg/providers/alibaba/eip.go, pkg/providers/alibaba/ack.go
The new providers retrieve SLB, ALB, EIP, and ACK resources. They paginate results and map addresses or endpoints into resource records.
Provider tests and service documentation
pkg/providers/alibaba/alibaba_test.go, PROVIDERS.md
Tests check resource values and classifications, paginated responses, and retention of an earlier SLB page after a later request fails. Documentation lists supported services and read-only RAM policies.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 6b5c9

The Alibaba service expansion is mergeable after normal checks. Live-account behavior remains untested, but no specific failure is established.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Out of Scope Changes check Warning The PR changes the existing ECS client from the SDK default configuration to an HTTPS client in pkg/providers/alibaba/alibaba.go. Issue #775 requests the new SLB/ALB, EIP, and ACK enumeration. The c… Remove the ECS HTTPS behavior change, or update the linked requirements and PR scope to explicitly include changing ECS transport to HTTPS.
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: adding Alibaba SLB, ALB, EIP, and ACK services.
Linked Issues check Passed Issue #775 requires enumeration of SLB/ALB load balancers, Elastic IPs, and ACK cluster endpoints. The PR adds providers for all four services, uses the configured region, implements pagination, and c…
Full details: Out of Scope Changes check

Explanation

The PR changes the existing ECS client from the SDK default configuration to an HTTPS client in pkg/providers/alibaba/alibaba.go. Issue #775 requests the new SLB/ALB, EIP, and ACK enumeration. The current PR scope describes HTTPS for the new services, not a behavior change for the existing ECS service.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the cloud by moonlit light,
Four new service trails appear in sight.
Load balancers, clusters, addresses flow,
Page by page, their records grow.
Then I nibble clover and hop home.

Comment @coderabbitai help to get the list of available commands.

@Mzack9999
Mzack9999 merged commit b847ec8 into dev Oct 8, 2026
9 checks passed
@Mzack9999
Mzack9999 deleted the feat/775-alibaba-slb-eip-ack branch October 8, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] alibaba: add SLB/ALB, EIP and ACK

2 participants