Improve performance of registry.metrics()#276
Closed
SerayaEryn wants to merge 1 commit into
Closed
Conversation
d6f2cf6 to
29b6d86
Compare
Contributor
|
Sorry for letting this sit. A lot of similar changes (the |
Contributor
|
@zbjornson Hi! |
Contributor
|
Thanks! will review that one this weekend. |
Contributor
|
Oops, I just realized the original author of this PR @SerayaEryn is not @doochik, who rebased it. doochik preserved the authorship of SerayaEryn's commit though so you'll still get attribution. @SerayaEryn alright with you? |
Contributor
Author
|
Yes, it is alright. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the performance of
registry.metrics()by approximately 40%.This is achieved by creating a specific formatter for each metric.
Here are the benchmark results: