Repository navigation
Pass all name[] values to the Django metrics view - #1250
Merged
csmarchbanks merged 1 commit intoNov 12, 2026
Merged
Conversation
PrometheusDjangoView passed request.GET straight to _bake_output. QueryDict['name[]'] returns only the last value as a string, so restricted_registry() built a set of its characters and /metrics?name[]=foo returned no metrics. Convert the QueryDict to a dict of lists, matching what parse_qs gives the WSGI app. Signed-off-by: sarankumar1325 <120080287+sarankumar1325@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrometheusDjangoViewpassesrequest.GET(aQueryDict) to_bake_outputasparams._bake_outputthen doesregistry.restricted_registry(params['name[]']), butQueryDict.__getitem__returns only the last value as a plain string.restricted_registryturns that into a set of characters, so/metrics?name[]=cc_totalreturns an empty body instead of thecc_totalmetric, and repeatingname[]only keeps the last one.The fix converts the query to a dict of lists (
dict(request.GET.lists())), which is the same shapeparse_qsgives the WSGI app.Tests: two new cases in
tests/test_django.py(single and multiplename[]values). Both fail on master and pass with the change. Full suite: 441 passed, 13 skipped. flake8 and isort are clean on the changed files.