wasmtime: add options for configuring between winch and cranelift#562
Open
leonm1 wants to merge 7 commits into
Open
wasmtime: add options for configuring between winch and cranelift#562leonm1 wants to merge 7 commits into
leonm1 wants to merge 7 commits into
Conversation
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
Signed-off-by: Matt Leon <mattleon@google.com>
mpwarres
approved these changes
Jul 15, 2026
Signed-off-by: Matt Leon <mattleon@google.com>
Winch is not supported on s390x Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
changed the title
Signed-off-by: Matt Leon <mattleon@google.com>
PiotrSikora
reviewed
Jul 15, 2026
PiotrSikora
left a comment
PiotrSikora
left a comment
Member
There was a problem hiding this comment.
Definitely +1 for adding winch, but:
- This is added as a configuration option, which doesn't match how other engine flavors are exposed in this library (e.g.
wamr-interp,wamr-jit,wamr-aot). - I'm not sure if the optimization levels have any meaningful impact, so they might be only adding unnecessary noise and maintenance burden. Do you have any benchmarks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Winch has significantly faster load times than cranelift, with negligible difference in runtime performance:
With this change, we will be ready to switch Envoy over to using Wasmtime with Winch by default.