Skip to content

drop share from the isolation lists - #45

Merged
caelaxie merged 1 commit into
mainfrom
cursor/share-not-isolation-81cc
Oct 26, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/share-not-isolation-81cc

Conversation

@caelaxie

@caelaxie caelaxie commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #38

isolated work is only Workspace: "branch". share stays the local exception in swarm and orchestrate.

head ea8a57d3fa42c09eaa8f46fb99effac38f535c07

harness on that sha. installed shipping.md has no "share" (grep exit 1) and matches the head blob. Validate plugin is green: https://github.com/pstack-ports/agy-pstack/actions/runs/40261542101/job/121374795727

$ agy plugin install https://github.com/pstack-ports/agy-pstack/tree/cursor/share-not-isolation-81cc
Cloning plugin from https://github.com/pstack-ports/agy-pstack.git...
  [ok]    pstack
          ✔ skills      : 61 processed
          ✔ agents      : 2 processed
          - commands    : skipped (not found)
          - mcpServers  : skipped (not found)
          - hooks       : skipped (not found)
exit:0

$ agy plugin list
Installed plugins:
- pstack (enabled, 0.15.32)
    Source:     antigravity
    Components: 61 skills, 2 agents
exit:0

$ git -C /tmp/agy-proof-45/.gemini/config/plugins/pstack rev-parse HEAD
ea8a57d3fa42c09eaa8f46fb99effac38f535c07
exit:0

$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/shipping.md
exit:1

$ grep -n 'Workspace: "branch"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/shipping.md
5:1. **Resolve the forge, then verify each PR independently before it lands.** GitHub CLI (`gh`) is the default. If `command -v origin` succeeds and Origin can resolve the repository, use `origin pr` for every PR operation. Otherwise stay on `gh` and record the fallback. Never require Graphite (`gt`). One verifier per PR, each in an isolated workspace (`Workspace: "branch"`), runs the change the way a user would with the matching control skill (such as `control-ui` or `control-cli`), parent against head, and posts `PASS`, `PASS+NOTES`, or `FAIL` on that PR. Only a verdict from an agent that did not write the code counts, because an author checks what it meant to build. Green CI and an approving bot review are not verdicts, because neither runs the change as a user would.
exit:0

$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:skills/poteto-mode/playbooks/shipping.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/shipping.md
exit:0

same sha, the other five changed files: "share" grep exit 1, cmp exit 0 (02-poteto-mode.md, 07-overnight.md, 10-recipes-and-pitfalls.md, autopilot-full.md, opening-a-pr.md). full transcript is on the pr comment.

Open in Web Open in Cursor 

isolated work is Workspace branch only. share stays the local exception in swarm and orchestrate.

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: changes requested (proof only).

content passes. the six edits are exactly the smallest fix from #38: or "share" / or Workspace: "share" deleted, nothing else touched, swarm and orchestrate exception text left alone. layout, parity, and Closes #38 linkage are fine, and validate is green on ea8a57d.

blocked on harness proof. this touches shipped skill text (skills/poteto-mode/playbooks/*), so validate alone doesn't cover it. post a comment showing agy plugin install + agy plugin list on the exact head ea8a57d, plus the installed copy of one changed playbook (e.g. shipping.md) showing the share mention gone. i'll merge on the next sweep once that lands.

@cursor

cursor Bot commented Oct 26, 2026

Copy link
Copy Markdown

harness on head ea8a57d3fa42c09eaa8f46fb99effac38f535c07. installed skills/poteto-mode/playbooks/shipping.md has no "share" (grep exit 1) and matches the head blob. the other five changed files match too. Validate plugin is green: https://github.com/pstack-ports/agy-pstack/actions/runs/40261542101/job/121374795727

$ agy --version
1.4.7
exit:0

$ agy plugin validate .
Validating pstack (.antigravity-plugin/plugin.json)

  ⚠ plugin.json: ignored: .antigravity-plugin/plugin.json takes precedence

  skills 61 · agents 2 · rules 0 · hooks 0 · mcpServers 0 · sidecars 0

✔ Validation passed with 1 warning
exit:0

$ agy plugin install https://github.com/pstack-ports/agy-pstack/tree/cursor/share-not-isolation-81cc
Cloning plugin from https://github.com/pstack-ports/agy-pstack.git...
  [ok]    pstack
          ✔ skills      : 61 processed
          ✔ agents      : 2 processed
          - commands    : skipped (not found)
          - mcpServers  : skipped (not found)
          - hooks       : skipped (not found)
exit:0

$ agy plugin list
Installed plugins:
- pstack (enabled, 0.15.32)
    Source:     antigravity
    Components: 61 skills, 2 agents
exit:0

$ git -C /tmp/agy-proof-45/.gemini/config/plugins/pstack rev-parse HEAD
ea8a57d3fa42c09eaa8f46fb99effac38f535c07
exit:0

$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/shipping.md
exit:1

$ grep -n 'Workspace: "branch"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/shipping.md
5:1. **Resolve the forge, then verify each PR independently before it lands.** GitHub CLI (`gh`) is the default. If `command -v origin` succeeds and Origin can resolve the repository, use `origin pr` for every PR operation. Otherwise stay on `gh` and record the fallback. Never require Graphite (`gt`). One verifier per PR, each in an isolated workspace (`Workspace: "branch"`), runs the change the way a user would with the matching control skill (such as `control-ui` or `control-cli`), parent against head, and posts `PASS`, `PASS+NOTES`, or `FAIL` on that PR. Only a verdict from an agent that did not write the code counts, because an author checks what it meant to build. Green CI and an approving bot review are not verdicts, because neither runs the change as a user would.
exit:0

$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:skills/poteto-mode/playbooks/shipping.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/shipping.md
exit:0

$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/docs/guide/02-poteto-mode.md
exit:1
$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:docs/guide/02-poteto-mode.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/docs/guide/02-poteto-mode.md
exit:0
$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/docs/guide/07-overnight.md
exit:1
$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:docs/guide/07-overnight.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/docs/guide/07-overnight.md
exit:0
$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/docs/guide/10-recipes-and-pitfalls.md
exit:1
$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:docs/guide/10-recipes-and-pitfalls.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/docs/guide/10-recipes-and-pitfalls.md
exit:0
$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/autopilot-full.md
exit:1
$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:skills/poteto-mode/playbooks/autopilot-full.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/autopilot-full.md
exit:0
$ grep -n '"share"' /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/opening-a-pr.md
exit:1
$ git show ea8a57d3fa42c09eaa8f46fb99effac38f535c07:skills/poteto-mode/playbooks/opening-a-pr.md | cmp - /tmp/agy-proof-45/.gemini/config/plugins/pstack/skills/poteto-mode/playbooks/opening-a-pr.md
exit:0

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass, merging.

content passed last round (six share deletions from #38, nothing else). proof is now on the exact head: agy 1.4.7 validate + install + list, installed shipping.md has no "share" and matches the head blob, Validate plugin green. Closes #38 set.

@caelaxie
caelaxie merged commit efbda04 into main Oct 26, 2026
1 check passed
@caelaxie
caelaxie deleted the cursor/share-not-isolation-81cc branch October 26, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: workspace share listed as isolation

2 participants