Repository navigation
port pstack 0.15.30 statechart skill - #30
Conversation
Copies the statechart skill and the README, guide, and poteto-help index lines from cursor/plugins 88d4751..4ec7ffa. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, since author and reviewer share an account).
checked at head 0e52080:
- all 12 files under
skills/statechart/are byte-identical to upstreampstack/skills/statechart/at 4ec7ffa1. - readme row, guide section, and poteto-help row match upstream; version bumps to 0.15.30 in
plugin.jsonand.factory-plugin/plugin.jsonmatch upstream. - no cursor-only files or paths added. ci (validate plugin) is green.
- no linked issue needed for a release port.
blocking: harness proof is still pending. add to the body or a comment, run against this exact head: droid plugin marketplace add of this branch, droid plugin install pstack@droid-pstack, droid plugin list showing pstack 0.15.30, and the installed skills/statechart/SKILL.md path + frontmatter. if droid exec is blocked only by auth, paste the verbatim error; install+list+installed copy is enough for this text-only change. i'll merge once that's up.
|
Harness proof against head
Installed statechart skill ( exit 1, stdout empty, stderr: |
caelaxie
left a comment
There was a problem hiding this comment.
pass. statechart matches upstream 4ec7ffa byte-for-byte, version 0.15.30, ci green on 0e52080, and harness proof (marketplace add + install + list at that head; statechart activated then auth-blocked) is on the pr. squash-merging.
Ports upstream
pstack/from88d4751to4ec7ffa(0.15.30).Upstream commits
eb4db2bfeat(pstack): add the statechart skill to draw TLA+ models as charts (#741)7698375fix(pstack): bring the statechart skill up to date with six fixes (#776)4ec7ffarefactor(pstack): delete statechart comments that repeat the code, and rename helpers (#779)No other
pstack/files changed in that range..cursor-plugin/plugin.jsononly bumps the version, and this port does not ship that Cursor manifest.Droid deviations
None inside the skill.
skills/statechart/is a byte-for-byte copy of upstreampstack/skills/statechart/at4ec7ffa. The new README row, guide section, andpoteto-helprow are the upstream lines unchanged. The skill text does not mention.cursor/skills/or any other Cursor-only path, so nothing was rewritten.The only repo-local edits are the version pin:
plugin.jsonand.factory-plugin/plugin.json:0.15.29→0.15.300.15.29→0.15.30Harness proof
Droid CLI
0.248.0. Head0e520801452131757116d08cde5dcc7d6c11dccd.The
#ref is rewritten (/becomes-), so the install id ispstack@droid-pstack@cursor-port-statechart-0-15-30-d59b, notpstack@droid-pstack. Installed commit matches this PR head. Cached manifests are0.15.30.Installed statechart skill:
/tmp/tmp.OQZRlM6khI/.factory/plugins/cache/droid-pstack@cursor-port-statechart-0-15-30-d59b-c7c5e6a8f1f8/pstack-7171b73fae68/0e5208014521/skills/statechart/SKILL.mddiff -rqof that installed tree against upstreampstack/skills/statechartat4ec7ffais empty.Installed
poteto-help(the other changed skill), same cache root.../0e5208014521/skills/poteto-help/SKILL.md. Diff against this repo'smainis only the upstream row:That line matches upstream. The rest of the file is the existing Droid port.
node statechart.mjs --helpexits 0.from-charton the bundledsync.mmdfixture, withtla2tools.jarv1.7.4, exits 1 because the fixture rule is broken and writes the chart:node --test skills/statechart/scripts/test/statechart.test.mjson the installed copy: 67 pass, 0 fail.droid execon the installed skill (noFACTORY_API_KEY), exit 1, stdout empty, stderr verbatim:Validate plugin on this PR: success (
39885577354).