Repository navigation
port pstack 0.15.32 - #31
Conversation
Bring the Droid port from upstream pstack 0.15.30 (4ec7ffa) through 0.15.32 (e73df47): statechart Pele renderer, ketchup-video, verify-skill statechart handoff, reflect cache routing, watch-pr and orch fixes, and the swarm numbering fix. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
changes requested (posting as comment; same account as author).
missing harness proof. the checks section has validate-plugin + unit tests, but no droid run on this head. need, against 8a66bfa:
droid plugin marketplace addpointing at this branch/headdroid plugin install pstack@droid-pstack- plugin list showing pstack 0.15.32, plus the installed copy showing the new
ketchup-videoskill and the updatedstatechart/reflectskills
if a live model turn is auth-blocked, install + list + installed-copy inspection on the exact head is enough for these text/script changes. post it as a pr comment or in the body.
also: ci is not green yet on this head (mergeable_state unstable). wait for it to pass.
content pass (verbatim vs upstream e73df47, the .factory/skills/ rewrite in reflect, the #806 skip) happens once proof lands. no issue linkage needed unless this fixes one.
|
Harness proof on head
Install root:
stdout empty, exit 1, stderr: Validate plugin on this head: https://github.com/pstack-ports/droid-pstack/actions/runs/40050888742 |
caelaxie
left a comment
There was a problem hiding this comment.
pass.
- verbatim: 36 of the 47 upstream files changed in 4ec7ffa..e73df47 are byte-identical at 8a66bfa, including all of statechart (Pele renderer files added, OutputFolder model deleted), ketchup-video, create-formal-verification-skill, check-plan, orch, and watch-pr types/policy.test. the other 10 files apply the same hunks as upstream line for line (docs guide, plugin.json, poteto-help, watch-pr github/github.test/policy, worktree-audit). the only differences are the droid paths in reflect (
.factory/skills/), the swarm renumber on top of the existing droid seat text, and the README pin. - skipped: #806 adds a claude code install paragraph to a README section this repo dropped in #29. fine.
- layout: no
.cursor-pluginor claude files. skills stay underskills/. - versions:
plugin.jsonand.factory-plugin/plugin.jsonare 0.15.32. cursor-team-kit has no changes in the range and stays at 1.2.0, same as upstream. - proof: the marketplace add, install and list are on 8a66bfa, and the installed files are shown. the install id carries the branch-ref suffix, which is how droid names a marketplace added from a branch. a live turn was blocked on auth, which is accepted.
- ci: validate plugin succeeded on 8a66bfa. no issue to close. not a draft.
Ports upstream
pstack/from4ec7ffa(0.15.30) throughe73df47(0.15.32).cursor-team-kitis unchanged since4ec7ffaand still1.2.0. No team-kit files moved.Upstream PRs
076f4b2feat(pstack): bring the statechart skill up to date, with the Pele renderer. Ported.skills/statechart/is a byte-for-byte copy of upstreampstack/skills/statechart/ate73df47.642289echore(pstack): bump to 0.15.31. Ported as the version pin. This repo does not ship.cursor-plugin/plugin.json. The bump lands onplugin.jsonand.factory-plugin/plugin.json, then #798 moves the same fields to0.15.32.00d5decfeat(pstack): tell generated verify skills to read each model-check result with /statechart. Ported.skills/create-formal-verification-skill/SKILL.mdmatches upstream.3c0fdb4feat(pstack): add the ketchup-video skill. Ported. Newskills/ketchup-video/SKILL.mdmatches upstream. The README skills-table row, the recipes-guide sentence, and thepoteto-helprow are the upstream lines.b1a1298chore(pstack): bump to 0.15.32. Ported.plugin.jsonand.factory-plugin/plugin.jsonare0.15.32. README header pin is0.15.32.marketplace.jsondoes not pin a version.7054003fix(pstack): route reflect edits out of the plugin cache. Ported onto the existing Droid reflect skill. The new sentence is upstream, with.cursor/skills/<skill>/rewritten to.factory/skills/<skill>/and~/.cursor/skills/<skill>/rewritten to~/.factory/skills/<skill>/, the paths this repo already uses for project and personal skills.96dec8efix(watch-pr): distinguish fork heads during stack discovery. Ported.github.ts,types.ts, andgithub.test.tstake the upstream change. The existing Droid reviewer check (factory-droid[bot]) stays.fe096effix(watch-pr): cap polling sleeps at the deadline. Ported.policy.tsandpolicy.test.tstake the upstream change. The existing Droid automation tokens stay.86c2448fix(pstack): recognize matching inline code delimiters. Ported.check-plan.mjsandcheck-plan.test.tsmatch upstream.3c596e7fix(orch): prefer active PR over branch history. Ported.orch/store.tsandorch/orch.test.tsmatch upstream.f83fbe6fix(pstack): read transcript mtimes with GNU stat and date in worktree-audit. Ported onto the existing script. The GNUstat/dateselection is upstream. The session directory stays~/.factory/sessions/.a0b0ad9docs(pstack): note Claude Code auto-update is off for third-party marketplaces. Skipped. The only change is a paragraph in the Claude Code install section ofpstack/README.md. This repo dropped that section with the Claude Code adapter in Restore the upstream README and drop the Claude Code adapter #29, and the README no longer carries it.e73df47fix(pstack): renumber swarm's Phase A and fix its dangling table reference. Ported onto the existing Droid swarm skill: Phase A is numbered 1 to 4, Phase B says "the step 3 seat", and Phase D asks for "a result table".harness/pstack/claude-code/copies regenerated by #791, #797, #800, and #807 are not carried. This repo does not ship that tree.Droid deviations in this range
.factory/skills/and~/.factory/skills/in place of.cursor/skills/and~/.cursor/skills/.step 3 seatrather than upstream'sstep 3 model).worktree-audit.sh,watch-pr, and the docs/help rows keep the Droid paths and reviewer names already onmain. The new upstream lines are otherwise unchanged.Checks
node scripts/validate-plugin.mjs: OK (61 skills, 5 droids).bun run typecheckandbun run testinskills/poteto-mode/scripts: 82 pass, 0 fail.node --test skills/statechart/scripts/test/statechart.test.mjs: 58 pass, 0 fail, 92 skipped (cannot find TLC).Harness proof
Droid CLI
0.248.0. Head8a66bfa2bfbb722529cc141c07c39f38e81a4e0e. NoFACTORY_API_KEY.The
#ref is rewritten (/becomes-), so the install id ispstack@droid-pstack@cursor-port-pstack-0-15-32-58ba, notpstack@droid-pstack. Installed commit matches this PR head. Cachedplugin.jsonand.factory-plugin/plugin.jsonare0.15.32. The install has 61 skills, includingketchup-video, and the five droids (comment-sicko,poteto-agent,poteto-agent-readonly,poteto-judgment,poteto-judgment-readonly). No droid file changed in this range.diff -rqof the installed tree against this commit is empty. Installed root:/tmp/tmp.TU6OuwdoTV/.factory/plugins/cache/droid-pstack@cursor-port-pstack-0-15-32-58ba-5091070280de/pstack-7171b73fae68/8a66bfa2bfbbInstalled
skills/ketchup-video/SKILL.md:Installed
skills/statechart/SKILL.mddescription:Installed
skills/create-formal-verification-skill/SKILL.md(the #794 paragraph):Installed
skills/poteto-help/SKILL.mdrow:Installed
skills/reflect/SKILL.md(the #800 sentence, Droid paths):Installed
skills/swarm/SKILL.md(the #807 renumber):droid execon each changed skill, stdout empty, exit 1, stderr verbatim: