Skip to content

use droid's worktree path in cleanup - #40

Merged
caelaxie merged 1 commit into
mainfrom
cursor/worktree-factory-path-7416
Oct 26, 2026
Merged

caelaxie merged 1 commit into
mainfrom
cursor/worktree-factory-path-7416

Conversation

@caelaxie

Copy link
Copy Markdown
Contributor

replace the cleanup example path with ~/.factory/worktrees/<group>/<repo>/.

Closes #34

Open in Web Open in Cursor 

Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: changes requested (blocked on proof only).

  • minimum changes: pass. one-line swap of the example path to ~/.factory/worktrees/<group>/<repo>/, rest of the sentence untouched, matches #34's smallest fix exactly.
  • layout/target: pass. no cursor paths added.
  • parity/versions: pass, no version change needed.
  • linkage: pass, Closes #34.
  • harness/ci proof: fail. Validate plugin is red on 07a0fc2 at the "Validate plugin with Droid CLI" step. main b5741f0 has also failed that step on every scheduled run since 2026-10-24, so this looks like droid cli drift, not this diff. either land a minimal ci/harness-compat fix first, or post droid plugin marketplace add + droid plugin install pstack@droid-pstack + plugin list on this exact head. merge once one of those is green.

@cursor

cursor Bot commented Oct 26, 2026

Copy link
Copy Markdown

head 07a0fc2958eb6319e94c0fd2a405cee05559deaf. proof with Droid 0.248.0 (the installer at https://app.factory.ai/cli is 0.249.0, which rejects every droid plugin marketplace add with Org plugin policy rejected this credential). CI was not changed.

$ droid --version
0.248.0
$ droid plugin marketplace add pstack-ports/droid-pstack#cursor/worktree-factory-path-7416
Successfully added marketplace: droid-pstack@cursor-worktree-factory-path-7416
$ droid plugin install pstack@droid-pstack@cursor-worktree-factory-path-7416 --scope user
Successfully installed pstack@droid-pstack@cursor-worktree-factory-path-7416 (07a0fc2)
$ droid plugin list
Installed plugins:
Enabled:
  pstack@droid-pstack@cursor-worktree-factory-path-7416  [user]  07a0fc2
$ droid exec "/poteto-mode clean up worktrees"
Skill "poteto-mode" activated
Error during droid execution: Authentication failed. Please log in using /login or set a valid FACTORY_API_KEY environment variable.

installed plugin copy skills/poteto-mode/playbooks/worktree-cleanup.md (this PR does not change a SKILL.md), line 3:

a hand-typed myrepo-worktrees/xmisses one that lives at~/.factory/worktrees///``

Validate plugin is red on this head because the runner installs Droid 0.249.0. the failing step is "Validate plugin with Droid CLI" (https://github.com/pstack-ports/droid-pstack/actions/runs/40262367068). main b5741f0 fails the same step and has since the 2026-10-24 run (latest: https://github.com/pstack-ports/droid-pstack/actions/runs/40258344594).

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proof verified at 07a0fc2: marketplace add, install and list on droid 0.248.0 show 07a0fc2, and the installed worktree-cleanup.md line 3 has ~/.factory/worktrees///, matching the head. ci red is the pre-existing droid 0.249.0 break on main b5741f0 ("Org plugin policy rejected this credential" in Validate plugin with Droid CLI, same as main run 40258344594). no other check fails. passes.

@caelaxie
caelaxie merged commit 4621c6a into main Oct 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit: worktree example path is not droid's

2 participants