Skip to content

fix(pstack): treat the bundled companion skills as always available - #4

Closed
caelaxie wants to merge 1 commit into
mainfrom
bundle-team-kit-skills
Closed

caelaxie wants to merge 1 commit into
mainfrom
bundle-team-kit-skills

Conversation

@caelaxie

@caelaxie caelaxie commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Why

#3 copied deslop, control-cli, and control-ui into the bundle, but the steps that call them still said "when installed" and told agents to fall back to manual work. agy-pstack, the reference port, treats them as bundled; this PR finishes that.

What changed

  • Remove the "when installed" guards and manual fallbacks in poteto-mode and six playbooks.
  • Add routing rows for the three in poteto-help.
  • Credit cursor-team-kit 1.2.0 in the README and record provenance in AGENTS.md.
  • Bump the port to 0.15.34.

Scope

Documentation and skill text only. The vendored skill files from #3 are untouched.

Verification

  • npm test — validated 61 skills, 23 playbooks, 24 principles, and the bundle manifest.
  • grep -rn "when installed" across .agents, docs, and README.md — no matches.
  • git diff --check — clean.

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: changes requested (comment review, same account).

  1. duplicate of #3. main already embeds deslop, control-cli and control-ui (#3 squash-merged as e1d47bb), and this branch is cut from before that, so it conflicts (mergeable_state: dirty). close it or rebase onto main and keep only whatever #3 genuinely missed.
  2. cursor-team-kit mentions. the port must not name cursor-team-kit anywhere: no "vendored from", no link, no version pin. drop the AGENTS.md sentence and the README attribution line (inline). the skills are just pstack skills here.
  3. version. main is 0.15.33 pinned to upstream pstack 0.15.32; a 0.15.34 bump has no upstream release behind it. leave versions alone.
  4. no dsh proof. needs dsh plugin --profile <p> add <checkout> on the exact head plus the bundle mounting with the embedded skills loaded. npm test / npm pack aren't harness proof.
  5. no Closes #N / Refs #N.

Comment thread AGENTS.md Outdated
# dsh-pstack

This repository is the DeepSeek Harness port of pstack 0.15.32. The skills are the upstream pstack content, adapted to DSH tool names, subagent semantics, and session logs.
This repository is the DeepSeek Harness port of pstack 0.15.32. The skills are the upstream pstack content, adapted to DSH tool names, subagent semantics, and session logs. `deslop`, `control-cli`, and `control-ui` are the exception: vendored verbatim from cursor-team-kit 1.2.0 (MIT, Eric Zakariasson), with only the attribution recorded in the README.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the added sentence. no cursor-team-kit provenance in the port; revert to the line on main.

Comment thread README.md Outdated

[`/poteto-mode`](./.agents/skills/poteto-mode/SKILL.md) runs most of these for you when a step needs them (`how`, `why`, `architect`, `arena`, `swarm`, `interrogate`, `unslop`, `no-comments`, `technical-writing`, `tdd`, and the principles). the table below is for when you want one directly:

pstack also bundles three companion skills from [cursor-team-kit](https://github.com/cursor/plugins/tree/main/cursor-team-kit) `1.2.0` by Eric Zakariasson: [`/deslop`](./.agents/skills/deslop/SKILL.md), [`/control-cli`](./.agents/skills/control-cli/SKILL.md), and [`/control-ui`](./.agents/skills/control-ui/SKILL.md).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this line. no cursor-team-kit link or attribution. main already lists the three skills without it.

deslop, control-cli, and control-ui now ship with the bundle, so the
steps that call them no longer need the "when installed" wording or a
manual fallback.

Add the three to the poteto-help table, credit cursor-team-kit 1.2.0 in
the README and AGENTS.md, and bump the port to 0.15.34.
@caelaxie
caelaxie force-pushed the bundle-team-kit-skills branch from ddde1af to a73e645 Compare October 27, 2026 01:32
@caelaxie caelaxie changed the title feat(pstack): bundle deslop, control-cli, and control-ui fix(pstack): treat the bundled companion skills as always available Oct 27, 2026
@caelaxie caelaxie closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant