Add migration to the config for rustfs - #1052
Merged
Merged
Conversation
mdellweg
force-pushed
the
migrate_rustfs
branch
from
September 16, 2026 07:22
fc1b0e7 to
30a60f1
Compare
gerrod3
reviewed
Sep 16, 2026
| # Migrate minio to rustfs | ||
| with suppress(KeyError): | ||
| if "s3boto3" in config["pulp_settings_s3"]["STORAGES"]["default"]["BACKEND"]: | ||
| config["pulp_settings_s3"]["STORAGES"]["default"]["OPTIONS"]["endpoint_url"] = ( |
Contributor
There was a problem hiding this comment.
Shouldn't this also check to see if the url is minio? This migration will always run even after the switch to rustfs?
Member
Author
There was a problem hiding this comment.
What even is the benefit for plugins to overwrite this config in the first place?
The parameters with which the container is started are in control of the plugin.
Otoh whatever we template here still goes through test and review on every single plugin branch. So i opt for not borrowing problems of another universe here.
(The whole scenario framework should be less centered around three select storage apis. But this is where we are today.)
gerrod3
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough