Fix nondeterministic simple API package ordering - #1396
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (19)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe publish task now uses deterministic secondary sort keys. CI scripts use inline metadata and uv execution. Package builds, Python versions, constraints, and S3 test infrastructure were updated. MinIO references were replaced with rustfs. ChangesPublish and CI workflow updates
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR makes package publication deterministic and updates CI tooling and storage configuration without a demonstrated merge-blocking production risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 10 files. (10 skipped: 10 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add stable secondary ordering for project names and package filenames when generating the Python simple API.\n\nAssisted-by: AI (Codex)
b2754bf to
bf452bd
Compare
Summary
This carries over the
publish.pychange from TenSt/pulp_python commitccae248a91bfc505b48e302db9829435d2b06d2aonly.Tests
source ~/devel/pulp/bin/activate && ruff check pulp_python/app/tasks/publish.pyoci-env; the test reached the publication assertion path but the generated internal HTTPS content URL refused the connection (ConnectionRefusedError).Summary by CodeRabbit