Repository navigation
Harden the deploy workflows against silent wrong-thing failures - #18
Merged
Merged
Conversation
- publish.yml: publish step name now names the package (1) - publish.yml: added run-name - publish.yml: added timeout-minutes to 1 job(s) - version.yml: dispatch input moved out of the shell line - version.yml: added run-name Part of the fleet sweep planned in igl-gotv docs/plans/workflow_hardening_sweep.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens release-related GitHub Actions workflows by improving run readability and reducing the chance of “wrong value in shell line” issues during version cutting and publishing.
Changes:
- Add human-readable
run-nametitles for dispatch/tag workflows. - Pass the version input via
env(instead of interpolating directly into therun:line) for the version-cut workflow. - Add/adjust workflow job timeouts and make publish step naming more descriptive.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| CHANGELOG.md | Documents workflow-hardening changes (currently overstates concurrency behavior). |
| .github/workflows/version.yml | Adds run-name and switches npm version to use an env var for the version string. |
| .github/workflows/publish.yml | Adds run-name, adds a timeout for the docs job, and updates publish step naming. |
Suppressed comments (1)
.github/workflows/version.yml:48
- The
VERSIONenv var is constructed by concatenatinginputs.versionandclient_payload.version. If both are present,npm versionwill be invoked with a concatenated (invalid) version. Prefer coalescing to ensure exactly one source is used.
VERSION: ${{ github.event.inputs.version }}${{ github.event.client_payload.version }}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| name: version | |||
| run-name: Cut ${{ github.event.inputs.version }}${{ github.event.client_payload.version }} | |||
| env: | ||
| POSTHOG_API_KEY: ${{ secrets.POSTHOG_API_KEY }} | ||
| - name: Publish | ||
| - name: Publish ${{ steps.version.outputs.name }}@${{ steps.version.outputs.current }} |
- reverted the publish.yml step-name rename - corrected the CHANGELOG bullet Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Acted on the review:
Not taken, with reasons:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fleet sweep from the plan in igl-gotv docs/plans/workflow_hardening_sweep.md, which carries the evidence for each change.
What changed here:
CHANGELOG updated.
Warning
version.yml,promote.yml,publish.ymlandredeploy.ymlare tag- or dispatch-triggered, so PR CI never exercises them. A green check here does not cover them - they were validated by parsing the YAML.