Skip to content

YAFC Support for Factorio 2.1 - #186

Closed
SpikesDivZero wants to merge 1 commit into
pyanodon:mainfrom
SpikesDivZero:yafc-ce-21
Closed

SpikesDivZero wants to merge 1 commit into
pyanodon:mainfrom
SpikesDivZero:yafc-ce-21

Conversation

@SpikesDivZero

Copy link
Copy Markdown

Require now only loads the source once across the entire data lifecycle, and returns the cached result on subsequent calls. This means that, for instance, the old _G.yafc_turd_integration approach no longer works.

Depends-On: pyanodon/pyalienlife#629
Refs: pyanodon/pybugreports#1576

Require now only loads the source once across the entire data lifecycle,
and returns the cached result on subsequent calls. This means that, for
instance, the old _G.yafc_turd_integration approach no longer works.

Depends-On: pyanodon/pyalienlife#629
Refs: pyanodon/pybugreports#1576
Comment thread prototypes/yafc.lua
data.raw["assembling-machine"]["bioport"].fixed_recipe = nil

Biofluid = {}
require "__pyalienlife__/scripts/biofluid/biofluid-prototypes"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe to remove completely. biofluid-prototypes seems to define favorite_foods and taco_bell as being near-constant, and I didn't see anything in the core py mod suite that looked like it significantly modified those vars outside that file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handling for this needs to be completely different, the data setup is separate from biofluid-prototypes now. Just removing it isn't the right solution

@protocol-1903

Copy link
Copy Markdown
Contributor

Using #196 instead, thank you for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants