feat: update Qt-Advanced-Docking-System to 5.1.1, drop py3.9, test on 3.14/3.15 - #25
Merged
Merged
Conversation
Closes pyapp-kit#24 - Update submodule to the v5.1.1 tag - Generate `ads_version.h` (now included by `ads_globals.h`, produced by CMake upstream) from `cmake/modules/ads_version.h.in` at build time - Bind the new `CAutoHideSideBar.wheelEvent` override - Declare `%MinimumABIVersion "13"`, required by sip >= 6.16 (used when building on Python >= 3.10) - Add a test for the new binding Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- Require Python >= 3.10; build the abi3 wheel on cp310 - Test the abi3 wheel on cp314 and cp315 via cibuildwheel - Upgrade cibuildwheel from v2.22 to v4.2 (needed for 3.14/3.15) - Add Python version classifiers - Fix pytest deprecation of passing a generator to parametrize Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Qt-Advanced-Docking-System 5.1.1
v5.1.1tagads_globals.hnow#includesads_version.h, which is generated by CMake (andsrc.prowas removed).project.pynow generates it fromcmake/modules/ads_version.h.ininto the sip build dir, using the version in the top-levelCMakeLists.txt.CAutoHideSideBar.wheelEventoverride (the only public header API change between 5.0.0 and 5.1.1), with a test%MinimumABIVersion "13": sip >= 6.16 errors without it (ABI v13 is being targeted but the PyQt6Ads._ads module doesn't support it). CI wasn't hitting this because the cp39 build env resolved sip 6.14 (sip >= 6.15 requires Python >= 3.10), but local builds on newer Python were broken. The directive is supported by sip 6.10+, and the targeted ABI is unchanged (pyqtbuild still picks 13.8).Python support
requires-python >= 3.10, ruff targetpy310)abi3audit --stricton abi3 wheels by default, and our wheels pass it.repair-wheel-command = ""on Windows: cibuildwheel 4 madedelvewheelthe default there, which tries to bundle the Qt DLLs (Unable to find library: qt6widgets.dll). Qt comes from PyQt6-Qt6, so we keep the previous no-repair behavior.parametrize)Testing
🤖 Generated with Claude Code