Keep mid-sized colored areas filled in black and white - #244
Open
toolicious wants to merge 1 commit into
Open
toolicious wants to merge 1 commit into
toolicious wants to merge 1 commit into
Conversation
Owner
|
@toolicious Thanks a lot for this new PR. The black and white processing is already quite complex, and as the maintainer of this project, I don't feel ready to expand it further at this point. I'll come back to it later. Thank you for your understanding. |
Contributor
Author
|
Sure, no rush. It's an edge case for mid-sized colored areas, so the release is fine without it. I'll leave the PR open for later. |
toolicious
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still running special cases through the b&w mode, and today I found this bug:
Mid-sized colored areas (like the buttons or the logo in the screenshot of your website) turn white with a black rim because flattening lightens them toward paper before the fill step runs. The fix adds a check on the original photo: a region that is clearly darker and distinctly colored versus its surroundings is content, one that matches the paper's tone is a shadow and left alone. This adds ~100ms per page (it runs on a 2MP copy) with no regressions elsewhere (as far as I can see).
It would be nice to have this in the first release. If that's too late for you, the next update is fine.