Skip to content

PluginManager.register leaves partial state after validation failure #733

Description

@sb123sb123

A failed PluginManager.register() call can leave a plugin partially registered when a later hook implementation fails validation. On main at 9836e54, a plugin with a valid a_hook and invalid b_hook raises PluginValidationError but remains in the manager and leaves a_hook installed. Expected: registration failure leaves no plugin mapping or hook implementations, so callers can safely fix and retry. The register implementation currently contains a TODO noting that state should not change on failure.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions