Make create_link error on cross-device links - #1338
Merged
mrbean-bremen merged 2 commits intoSep 9, 2026
Merged
Conversation
shannonmcin
force-pushed
the
cross-device-hard-link
branch
from
September 8, 2026 21:56
60080c5 to
603bd03
Compare
shannonmcin
marked this pull request as ready for review
September 8, 2026 21:57
mrbean-bremen
left a comment
mrbean-bremen
left a comment
Member
There was a problem hiding this comment.
Thanks - looks good apart from the test that has to be adapted.
mrbean-bremen
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
See #1337
The current hardlink implementation in pyfakefs does not raise an error on a cross-device link, while
os.filedoes. This PR raises an OSError if the source and destination files have different device IDs.Unit test pass:
Tasks
For documentation changes: The Read the Docs preview builds and looks as expected