Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are documented and no unresolved issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates the adhoc-layout example to use Coverage.py’s source_pkgs configuration and documents why tests run from the tests directory.
Changes:
- Replaces
sourcewithsource_pkgs = example. - Clarifies installed-package imports and the purpose of
changedir = tests.
| File | Description |
|---|---|
examples/README.rst |
Documents the updated configuration. |
examples/adhoc-layout/.coveragerc |
Targets the installed package via source_pkgs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the adhoc-layout example to select the installed
examplepackage with coverage.py’ssource_pkgssetting. Explain whychangedir = testsremains necessary: it makes the test import the installed package instead of the source checkout.This addresses the configuration/documentation request in #496 without changing pytest-cov runtime behavior.
Verification
pytest --cov --cov-config=../.coveragercfromexamples/adhoc-layout/tests: 1 passed; onlyexample/__init__.pyappeared in the coverage table.sphinx-build -b dummy docs /tmp/nkoo-pytest-cov-sphinxpassed.git diff --checkpassed.The full tox matrix was not run locally; its configured PyPy/Python 3.11 interpreters are not available in this environment.