Add django-upgrade dependency - #1298
Merged
Merged
Conversation
- Added `django-upgrade==1.31.1` to the linting dependencies in `pyproject.toml`. - Updated `tox.ini` to include a command for running `django-upgrade` on specified directories. These changes enhance the linting process by incorporating Django upgrade checks.
Member
|
I'm not sure django-upgrade is a good fit here, since we need to be somewhat careful about our Django usage. So normally when Django adds a deprecation warning, we handle it with a conditional or such. |
Member
Author
|
I'll remove it, my thought here was more so we can catch it before hand. But I see your point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
django-upgrade==1.31.1to the linting dependencies inpyproject.toml.tox.inito include a command for runningdjango-upgradeon specified directories.These changes enhance the linting process by incorporating Django upgrade checks.