Fix bare exception class in only_rerun / rerun_except causing INTERNALERROR - #362
Open
janmrow wants to merge 2 commits into
Open
Fix bare exception class in only_rerun / rerun_except causing INTERNALERROR#362janmrow wants to merge 2 commits into
janmrow wants to merge 2 commits into
Conversation
janmrow
marked this pull request as ready for review
September 6, 2026 16:55
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
only_rerunandrerun_exceptin@pytest.mark.flakyto accept a single exception class directly.Before the fix passing a bare exception class name instead of a list, caused an
INTERNALERROR. The value is now handled as a single filter, consistently with string arguments.Reproduction:
Before:
INTERNALERROR: TypeError: 'type' object is not iterable.After:
1 failed, 2 rerun.