Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extending a URI query currently drops existing parameters with empty values because
parse_qsluses its defaultkeep_blank_values=False. For example, extendinga=&a=1retains onlya=1.Keep blank values when parsing the original query. Three regression cases cover empty values, repeated parameters, valueless flags, and preserving the original builder.
Validation: all three regressions fail before the fix; all 2,917 tests pass with 100% source coverage. Black, isort and Flake8 pass. The configured Pyright type-completeness gate passes at 76.95% (75% required).
A valueless flag is retained and normalized to
flag=, consistent with the builder’s query serialization.