Repository navigation
fix: grammar according to rfc3987 - #10
Merged
Merged
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
…cording_t-rfxc3987
jkowalleck
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the RFC 3987 Lark grammar to better match the RFC’s ABNF definitions (notably ucschar, iprivate, and IPv6address), and extends the valid-syntax test corpus to cover the corrected ranges and IPv6 forms.
Changes:
- Expanded
ucscharandiprivateto include the full RFC 3987 Unicode ranges (including supplementary planes). - Refactored
IPv6addressgrammar alternatives into a more compact repetition-based form. - Added new valid syntax test cases for
ucschar,iprivate, and selectedIPv6addresspatterns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/valid_syntax.json | Adds new valid syntax examples intended to cover RFC-specified Unicode ranges and IPv6 forms. |
| src/rfc3987_syntax2/syntax_rfc3987.lark | Updates grammar productions for ucschar, iprivate, and refactors ipv6address alternatives. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jkowalleck
commented
Jul 16, 2026
Co-authored-by: Jan Kowalleck <jan.kowalleck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviewed the grammar (lark) in comparison to the RFC 3987 (ABNF) - https://www.rfc-editor.org/rfc/rfc3987#section-2.2
found some issues and ...
see the tests failing in #9