Skip to content

feat: typing - #16

Merged
jkowalleck merged 6 commits into
mainfrom
feat/typing
Jul 16, 2026
Merged

jkowalleck merged 6 commits into
mainfrom
feat/typing

Conversation

@jkowalleck

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the enhancement New feature or request label Jul 16, 2026
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces explicit typing metadata and CI static type checking to treat rfc3987_syntax2 as a typed package and enforce mypy-based validation.

Changes:

  • Added mypy strict configuration and a dedicated GitHub Actions job to run mypy.
  • Marked the distribution as typed (PEP 561 py.typed + Typing :: Typed classifier).
  • Tightened/added return and callable type annotations in helpers and tests.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_syntax.py Adds typing imports and a return annotation for a generator used in parametrized tests.
tests/__init__.py Adds mypy ignore comments on json.load returns (needs a small fix).
src/rfc3987_syntax2/utils.py Adds an explicit -> str return type to load_grammar.
src/rfc3987_syntax2/syntax_helpers.py Adds typing import and explicit return types for public helpers and validator factory.
src/rfc3987_syntax2/py.typed Adds PEP 561 marker file to indicate inline type hints are shipped.
pyproject.toml Declares Typing :: Typed and adds mypy to testing extras.
CHANGELOG.md Notes the addition of static typing assertions.
.mypy.ini Introduces strict mypy configuration (scoped to src/).
.github/workflows/python-tests.yml Adds a static analysis job running mypy (one step name should be corrected).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/__init__.py Outdated
Comment thread tests/__init__.py Outdated
Comment thread .github/workflows/python-tests.yml Outdated
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck
jkowalleck merged commit d172ffb into main Jul 16, 2026
19 checks passed
@jkowalleck
jkowalleck deleted the feat/typing branch July 16, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants