Repository navigation
fix(parsing): allow more than 9 subsecond digits in ISO 8601 - #1055
Open
christiandovison6-droid wants to merge 2 commits into
Open
christiandovison6-droid wants to merge 2 commits into
christiandovison6-droid wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pendulum.parse()raisesParserErroron ISO 8601 strings with morethan 9 fractional-second digits, e.g.:
The pure-Python parser bounded the subsecond capture group to
\d{1,9}.The Rust extension and
datetime.datetime.fromisoformat()both acceptlonger fractions and truncate to microsecond precision.
Fix
Widen the subsecond capture group in
src/pendulum/parsing/iso8601.pyfrom
\d{1,9}to\d+. The existing[:6]truncation already handlesarbitrary-length fractions.
Tests
Added
test_parse_iso8601_subsecond_more_than_nine_digitsintests/parsing/test_parse_iso8601.py. It fails before the change andpasses after. Full
tests/parsing/suite passes.Closes #935