Skip to content

Encode hostnames consistently - #3566

Open
A5rocks wants to merge 2 commits into
python-trio:mainfrom
A5rocks:idna-consistently
Open

A5rocks wants to merge 2 commits into
python-trio:mainfrom
A5rocks:idna-consistently

Conversation

@A5rocks

@A5rocks A5rocks commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #11.

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (9f2df4e) to head (f71cbda).

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3566   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19479        19489   +10     
  Branches         1323         1323           
===============================================
+ Hits            19479        19489   +10     
Files with missing lines Coverage Δ
src/trio/_socket.py 100.00000% <100.00000%> (ø)
src/trio/_ssl.py 100.00000% <100.00000%> (ø)
src/trio/_tests/test_ssl.py 100.00000% <100.00000%> (ø)
src/trio/lowlevel.py 100.00000% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CoolCat467 CoolCat467 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems with this, mostly just exporting an interface we already had internally.

@A5rocks

A5rocks commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Going to close and reopen to tell codecov to recompute coverage.

@A5rocks A5rocks closed this Oct 29, 2026
@A5rocks A5rocks reopened this Oct 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trio.ssl handling for Unicode (IDNA) domains is deeply broken

2 participants