Skip to content

Feat/1293 download dispatch - #1338

Merged
LalatenduMohanty merged 1 commit into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1293-download-dispatch
Oct 13, 2026
Merged

Feat/1293 download dispatch#1338
LalatenduMohanty merged 1 commit into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1293-download-dispatch

Conversation

@LalatenduMohanty

@LalatenduMohanty LalatenduMohanty commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Pull Request Description

Route configured source downloads through their resolver so the download boundary exposes artifact kinds to later phases while preserving legacy package behavior.

Closes #1293

@LalatenduMohanty
LalatenduMohanty requested a review from a team as a code owner September 18, 2026 22:16
@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: be1f3231-6688-4d2a-b246-226fb6f9c1e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LalatenduMohanty
LalatenduMohanty changed the base branch from main to new-resolver-config September 18, 2026 22:16
@mergify mergify Bot added the ci label Sep 18, 2026
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch from b777a35 to 73a31b2 Compare September 18, 2026 22:37
@LalatenduMohanty
LalatenduMohanty marked this pull request as draft September 18, 2026 22:37
@LalatenduMohanty
LalatenduMohanty marked this pull request as ready for review September 21, 2026 14:58
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch 4 times, most recently from ccc670f to ef28435 Compare September 21, 2026 21:09
rd4398
rd4398 reviewed Oct 1, 2026
View reviewed changes

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good! I have left couple of comments which are mostly nits and non-blockers.
I can approve when commit message is fixed

Comment thread src/fromager/sources.py
Comment thread src/fromager/bootstrapper/_bootstrapper.py Outdated
@rd4398

rd4398 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

The commit body says:

Also implement resolver_provider() for the hook-sdist and hook-prebuilt resolver profiles, which invoke the package's get_resolver_provider override hook and validate the result.

I don't see any changes to HookSDistResolver or HookPrebuiltResolver in this diff. Their resolver_provider() and download() methods still raise NotImplementedError (lines 748-758 in _resolver.py). Am I missing something? If not, can you please correct the commit message?

@LalatenduMohanty

LalatenduMohanty commented Oct 13, 2026

Copy link
Copy Markdown
Member Author

@rd4398 good catch about the commit message, I am fixing it.

@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch 2 times, most recently from ef28435 to f597f48 Compare October 13, 2026 16:10
@LalatenduMohanty @claude
feat(sources): dispatch configured source downloads
8b94678 
New `source:` profiles can download more than sdists. Dispatch
configured downloads through their resolver and return
`(Path, DownloadKind)` so later phases can handle each artifact.
Keep the legacy hook path for packages without `source:`.

Closes: python-wheel-build#1293

Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1293-download-dispatch branch from f597f48 to 8b94678 Compare October 13, 2026 17:23
@LalatenduMohanty LalatenduMohanty mentioned this pull request Oct 13, 2026
Closed
rd4398
rd4398 approved these changes Oct 13, 2026
View reviewed changes

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the commit message fix

@mergify

mergify Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@LalatenduMohanty
LalatenduMohanty merged commit 384d743 into python-wheel-build:new-resolver-config Oct 13, 2026
38 checks passed
@mergify

mergify Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Waiting for
  • -closed [📌 queue requirement]
All conditions
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = @mergify/Configuration changed
    • check-success = @mergify/Configuration has been deleted
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • #review-threads-unresolved = 0 [🛡 GitHub repository ruleset rule new-resolver-config]
      • github-review-approved [🛡 GitHub repository ruleset rule new-resolver-config]

@mergify mergify Bot added the queued label Oct 13, 2026
@mergify

mergify Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

queue

☑️ The pull request has been merged manually

Details

The pull request has been merged manually at 384d743

@mergify mergify Bot removed the queued label Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rd4398 rd4398 rd4398 approved these changes

Assignees

No one assigned

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add source_resolver dispatch to download pipeline

2 participants

@LalatenduMohanty @rd4398