Repository navigation
Feat/1331 typed download result - #1344
LalatenduMohanty merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
68a8dbd to
017e574
Compare
Replace `tuple[Path, DownloadKind]` with a frozen `DownloadedSource` dataclass so the download contract is stable before Phase 4 consumes the artifact kind to select prepare/build strategies. Implement `HookSDistResolver.download()` and `HookPrebuiltResolver.download()` through the `download_source` override hook. For legacy hooks returning a bare `Path`, `HookSDistResolver` treats `.tar.gz` and `.zip` files as `sdist`, while `HookPrebuiltResolver` treats `.whl` files as `prebuilt_wheel`. Bare directories and other path forms require `DownloadedSource` with an explicit supported kind. Reject `any_source`, `not_available`, and kinds incompatible with the selected profile. Closes: python-wheel-build#1331 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
017e574 to
5c9ed71
Compare
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
448cfef
into
python-wheel-build:new-resolver-config
Replace
tuple[Path, DownloadKind]with a frozenDownloadedSourcedataclass so the download contract is stable before Phase 4 consumes
the artifact kind to select prepare/build strategies.
Implement
HookSDistResolver.download()andHookPrebuiltResolver.download()through thedownload_sourceoverridehook. For legacy hooks returning a bare
Path,HookSDistResolvertreats
.tar.gzand.zipfiles assdist, whileHookPrebuiltResolvertreats
.whlfiles asprebuilt_wheel. Bare directories and other pathforms require
DownloadedSourcewith an explicit supported kind.Reject
any_source,not_available, and kinds incompatible with theselected profile.
Closes: #1331