Skip to content

Feat/1331 typed download result - #1344

Merged
LalatenduMohanty merged 1 commit into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1331-typed-download-result
Oct 15, 2026
Merged

LalatenduMohanty merged 1 commit into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1331-typed-download-result

Conversation

@LalatenduMohanty

@LalatenduMohanty LalatenduMohanty commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Replace tuple[Path, DownloadKind] with a frozen DownloadedSource
dataclass so the download contract is stable before Phase 4 consumes
the artifact kind to select prepare/build strategies.

Implement HookSDistResolver.download() and
HookPrebuiltResolver.download() through the download_source override
hook. For legacy hooks returning a bare Path, HookSDistResolver
treats .tar.gz and .zip files as sdist, while HookPrebuiltResolver
treats .whl files as prebuilt_wheel. Bare directories and other path
forms require DownloadedSource with an explicit supported kind.
Reject any_source, not_available, and kinds incompatible with the
selected profile.

Closes: #1331

@LalatenduMohanty
LalatenduMohanty requested a review from a team as a code owner September 22, 2026 23:52
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0b1fd9d3-f1ec-4158-a582-eda9fbf1c84e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LalatenduMohanty
LalatenduMohanty marked this pull request as draft September 22, 2026 23:53
@mergify mergify Bot added the ci label Sep 22, 2026
@mergify

mergify Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.
@LalatenduMohanty please rebase your branch.

@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1331-typed-download-result branch from 68a8dbd to 017e574 Compare October 14, 2026 21:47
@LalatenduMohanty
LalatenduMohanty marked this pull request as ready for review October 14, 2026 21:47
Replace `tuple[Path, DownloadKind]` with a frozen `DownloadedSource`
dataclass so the download contract is stable before Phase 4 consumes
the artifact kind to select prepare/build strategies.

Implement `HookSDistResolver.download()` and
`HookPrebuiltResolver.download()` through the `download_source` override
hook. For legacy hooks returning a bare `Path`, `HookSDistResolver`
treats `.tar.gz` and `.zip` files as `sdist`, while `HookPrebuiltResolver`
treats `.whl` files as `prebuilt_wheel`. Bare directories and other path
forms require `DownloadedSource` with an explicit supported kind.
Reject `any_source`, `not_available`, and kinds incompatible with the
selected profile.

Closes: python-wheel-build#1331
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1331-typed-download-result branch from 017e574 to 5c9ed71 Compare October 14, 2026 22:15

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks

@mergify

mergify Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@LalatenduMohanty
LalatenduMohanty merged commit 448cfef into python-wheel-build:new-resolver-config Oct 15, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants