Skip to content

fix(sources): log PKG-INFO stub creation at INFO - #1363

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
ryanpetrello:fix/pkg-info-log-level
Oct 7, 2026
Merged

mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
ryanpetrello:fix/pkg-info-log-level

Conversation

@ryanpetrello

Copy link
Copy Markdown
Contributor

Use INFO for expected stub creation in ensure_pkg_info().

Use INFO for expected stub creation in `ensure_pkg_info()`.

Co-Authored-By: Codex <codex@openai.com>
Signed-off-by: Ryan Petrello <rpetrell@redhat.com>
@ryanpetrello
ryanpetrello requested a review from a team as a code owner October 7, 2026 11:50
@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 02a14efe-3d69-46e4-9924-82c8f39ce55d
📥 Commits

Reviewing files that changed from the base of the PR and between 5f5bbd9 and c4ccc98.

📒 Files selected for processing (1)
  • src/fromager/sources.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

When PKG-INFO is missing, ensure_pkg_info now logs the message at info level instead of warning. Stub-file creation and return behavior are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c4ccc

The expected missing-PKG-INFO message is now logged at info level, with stub behavior unchanged; no actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change: logging PKG-INFO stub creation at INFO level.
Description check ✅ Passed The description accurately states that ensure_pkg_info() uses INFO for expected stub creation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
mergify Bot merged commit 3d1b232 into python-wheel-build:main Oct 7, 2026
39 checks passed
@mergify

mergify Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants