Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rd4398
left a comment
There was a problem hiding this comment.
This looks good, I left a non-blocking comment which can be a follow up.
Reject conflicting source and legacy settings during package settings loading, including explicit pre_built: false. Cover both configuration directions with focused tests and document the rule. Co-Authored-By: Codex <codex@openai.com> Closes: #1368 Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>
118438d to
cc28550
Compare
rd4398
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
|
Tick the box to add this pull request to the merge queue (same as
|
Reject conflicting new resolver "source" and legacy settings during package settings loading, including explicit pre_built: false. Cover both configuration directions with focused tests and document the rule.
Closes: #1368
Pull Request Description
What
Why