Skip to content

fix(packagesettings): reject cross-level (package level and variant level) settings conflicts for source - #1369

Open
smoparth wants to merge 1 commit into
new-resolver-configfrom
codex/issue-1368-validation
Open

smoparth wants to merge 1 commit into
new-resolver-configfrom
codex/issue-1368-validation

Conversation

@smoparth

@smoparth smoparth commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Reject conflicting new resolver "source" and legacy settings during package settings loading, including explicit pre_built: false. Cover both configuration directions with focused tests and document the rule.

Closes: #1368

Pull Request Description

What

Why

@smoparth
smoparth requested a review from a team as a code owner October 14, 2026 14:57
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: python-wheel-build/fromager/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dec784de-0a4a-42f5-8f4b-aa7352cbcd11

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Oct 14, 2026
@smoparth smoparth changed the title fix(packagesettings): reject cross-level source conflicts fix(packagesettings): reject cross-level (package level and variant level) source conflicts Oct 14, 2026
@smoparth smoparth changed the title fix(packagesettings): reject cross-level (package level and variant level) source conflicts fix(packagesettings): reject cross-level (package level and variant level) settings conflicts for source Oct 14, 2026
rd4398
rd4398 previously approved these changes Oct 14, 2026

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I left a non-blocking comment which can be a follow up.

Comment thread src/fromager/packagesettings/_models.py Outdated
Reject conflicting source and legacy settings during package settings loading, including explicit pre_built: false. Cover both configuration directions with focused tests and document the rule.

Co-Authored-By: Codex <codex@openai.com>
Closes: #1368
Signed-off-by: Shanmukh Pawan <smoparth@redhat.com>

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@mergify

mergify Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants