Repository navigation
shutil.copytree: Give the option to disable copystat #89721
Description
| BPO | 45558 |
|---|---|
| Nosy | @jaraco, @doronbehar |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2021-10-21.20:20:18.081>
labels = ['type-feature', 'library', '3.11']
title = 'shutil.copytree: Give the option to disable copystat'
updated_at = <Date 2021-11-27.23:01:38.428>
user = 'https://github.com/doronbehar'bugs.python.org fields:
activity = <Date 2021-11-27.23:01:38.428>
actor = 'doronbehar'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2021-10-21.20:20:18.081>
creator = 'doronbehar'
dependencies = []
files = []
hgrepos = []
issue_num = 45558
keywords = ['patch']
message_count = 2.0
messages = ['407053', '407175']
nosy_count = 2.0
nosy_names = ['jaraco', 'doronbehar']
pr_nums = ['29130']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45558'
versions = ['Python 3.11']
Activity
jaraco commentedon Nov 26, 2021
Can you provide a description of what motivated you to change the behavior or what benefits this change would have for you or others? Do you know why others haven’t reported this need previously?
doronbehar commentedon Nov 27, 2021
Sometimes, you wish to copy a whole directory from a read-only file system and you don't want it to be read-only in the destination.
On NixOS all of the files that belong to packages are read-only. I encountered the need for this feature in GNURadio, at:
gnuradio/gnuradio#5227
The following Stack overflow question also suggests the need for this functionality is a bit common:
https://stackoverflow.com/a/17022146/4935114
max-privatevoid commentedon Mar 3, 2023
Facing this issue as well. Various Python software uses
shutil.copytreeto initialize state directories from a skeleton directory shipped with the software. With mutable package managers, all the files in package directories are read-write, so the problem doesn't become apparent. In the case of Nix and other package managers that install packages into immutable locations, this causes a surprising breakage.shutil.copytreealready provide an argumentcopy_function, which allows disabling this behavior for files, but directories always get their permissions copied.InvokeAI: ad-hoc patch init script to avoid wrong permissions
pythongh-89721: Skip copy_dir_stat tests without working chmod
pythongh-89721: Address review: kw-only flag, clearer docs, time asserts