Skip to content

gh-152373: Make pdb "until" step over a list comprehension with a breakpoint - #152374

Merged
gaogaotiantian merged 2 commits into
python:mainfrom
tonghuaroot:fix-gh-pdb-until-comprehension
Oct 20, 2026
Merged

gh-152373: Make pdb "until" step over a list comprehension with a breakpoint#152374
gaogaotiantian merged 2 commits into
python:mainfrom
tonghuaroot:fix-gh-pdb-until-comprehension

Conversation

@tonghuaroot

@tonghuaroot tonghuaroot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

until re-stops on a list comprehension (or single-line loop) line when a
breakpoint is set on it, because set_until does not record the frame and
line where the command was issued. next and step already record this
(gh-136160), so the existing same-line guard in dispatch_line applies to
them. This records it for set_until too, so until steps past the line like
next and step do.

@bedevere-app bedevere-app Bot mentioned this pull request Jun 27, 2026
Open
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 5, 2026
@gaogaotiantian gaogaotiantian removed the stale Stale PR or inactive for long period of time. label Oct 19, 2026
@gaogaotiantian gaogaotiantian added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 20, 2026
@gaogaotiantian
gaogaotiantian merged commit 7436707 into python:main Oct 20, 2026
63 checks passed
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @tonghuaroot for the PR, and @gaogaotiantian for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159957 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159958 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
gaogaotiantian pushed a commit that referenced this pull request Oct 20, 2026
@miss-islington @tonghuaroot
[3.15] gh-152373: Make pdb "until" step over a list comprehension wit…
6a23dc7 
…h a breakpoint (GH-152374) (#159957)

gh-152373: Make pdb "until" step over a list comprehension with a breakpoint (GH-152374)
(cherry picked from commit 7436707)

Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com>
gaogaotiantian pushed a commit that referenced this pull request Oct 20, 2026
@miss-islington @tonghuaroot
[3.14] gh-152373: Make pdb "until" step over a list comprehension wit…
b0a0405 
…h a breakpoint (GH-152374) (#159958)

gh-152373: Make pdb "until" step over a list comprehension with a breakpoint (GH-152374)
(cherry picked from commit 7436707)

Co-authored-by: tonghuaroot (童话) <tonghuaroot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonghuaroot @gaogaotiantian