Repository navigation
gh-155428: align hmac.digest and hmac.HMAC.digest outputs when using small block sizes - #155429
Merged
picnixz merged 3 commits intoOct 21, 2026
Conversation
…hen using small block sizes
picnixz
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 52660b0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F155429%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
Ah crap. Wrong PR. I didn't want to request the buildbot fleet for this PR... |
gpshead
approved these changes
Aug 10, 2026
gpshead
left a comment
gpshead
left a comment
Member
There was a problem hiding this comment.
wow .block_size vs .blocksize is confusing.
picnixz
marked this pull request as ready for review
October 19, 2026 20:04
picnixz
added
needs backport to 3.14
picnixz
deleted the
meta/crypto/py/hmac/54-digest-direct-invalid-155428
branch
October 21, 2026 17:06
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160060 is a backport of this pull request to the 3.15 branch. |
|
GH-160061 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still need to add tests but I don't have time today.
hmac.digest()andHMAC(...).digest()disagree when blocksize is smaller than 16 #155428