gh-156667: Add DOM Level 3 names to minidom - #156696
Open
Wanbinyu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minidommethods and attributesgetFeature(feature, version)follows the final DOM Level 3 signature, while the existing one-argumentgetInterface(feature)behavior is preserved. The new attribute names share their values with the existing names.Closes #156667
Tests
PCbuild\amd64\python_d.exe -m test -u cpu test_minidom test_pulldom test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml test_saxPCbuild\amd64\python_d.exe Tools\patchcheck\patchcheck.pyPCbuild\build.bat -p x64 -c Debug(0 warnings, 0 errors)This contribution was prepared with assistance from OpenAI Codex. I reviewed, adjusted, and tested the resulting changes.