Skip to content

gh-156667: Add DOM Level 3 names to minidom - #156696

Open
Wanbinyu wants to merge 1 commit into
python:mainfrom
Wanbinyu:gh-156667-minidom-dom-level-3-names
Open

gh-156667: Add DOM Level 3 names to minidom#156696
Wanbinyu wants to merge 1 commit into
python:mainfrom
Wanbinyu:gh-156667-minidom-dom-level-3-names

Conversation

@Wanbinyu

@Wanbinyu Wanbinyu commented Aug 31, 2026

Copy link
Copy Markdown

Summary

  • add the DOM Level 3 Recommendation names for the affected minidom methods and attributes
  • keep the names from the earlier working drafts working as compatibility aliases
  • add regression tests for the new names and a Library NEWS entry

getFeature(feature, version) follows the final DOM Level 3 signature, while the existing one-argument getInterface(feature) behavior is preserved. The new attribute names share their values with the existing names.

Closes #156667

Tests

  • PCbuild\amd64\python_d.exe -m test -u cpu test_minidom test_pulldom test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml test_sax
  • PCbuild\amd64\python_d.exe Tools\patchcheck\patchcheck.py
  • PCbuild\build.bat -p x64 -c Debug (0 warnings, 0 errors)

This contribution was prepared with assistance from OpenAI Codex. I reviewed, adjusted, and tested the resulting changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xml.dom.minidom uses names from superseded drafts of DOM Level 3

1 participant