Repository navigation
gh-154175: Remove time.sleep in test_io daemon test - #157019
Merged
Merged
Conversation
Deterministically get into the deadlock timeout by using mocked Raw I/O that blocks on threading events. The test still takes quite a bit of walltime as `_enter_buffered_busy` has a 1 second timeout on a lock acquisition which this hits.
msullivan
reviewed
Oct 21, 2026
msullivan
left a comment
msullivan
left a comment
Contributor
There was a problem hiding this comment.
Test sleeps must be destroyed!
cmaloney
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @cmaloney for commit 56984ad 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157019%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Contributor
|
buildbot failures unrelated, landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deterministically get into the deadlock timeout by using mocked Raw I/O that blocks on threading events. The test still takes quite a bit of walltime as
_enter_buffered_busyhas a 1 second timeout on a lock acquisition which this hits.