Repository navigation
gh-83731: Test that isinstance() ignores tuple subclass methods - #158000
Merged
Merged
Conversation
Add a regression test to make sure isinstance() reads the items of a tuple subclass directly, without calling its __iter__(), __getitem__() or __len__().
methane
approved these changes
Sep 23, 2026
picnixz
added
needs backport to 3.13
Contributor
Author
|
@methane Thanks for the approval! Is there anything else I can do before this can be merged? |
|
Sorry, @vasiliyk and @methane, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-159509 is a backport of this pull request to the 3.15 branch. |
|
GH-159510 is a backport of this pull request to the 3.14 branch. |
|
GH-159565 is a backport of this pull request to the 3.13 branch. |
Member
|
I don't think this need to be backported. This test is only for guard from future breakage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test to make sure
isinstance()reads the items of a tuple subclass directly, without calling its__iter__(),__getitem__()or__len__().Following @pganssle suggestion to lock in current behaviour so that a future change to the tuple handling can't start using these methods by accident.