Repository navigation
gh-159398: Validate strings read from remote process in _remote_debugging - #159402
Open
StanFromIreland wants to merge 5 commits into
Open
StanFromIreland wants to merge 5 commits into
StanFromIreland wants to merge 5 commits into
Conversation
vstinner
reviewed
Oct 14, 2026
Co-authored-by: vstinner@python.org
Contributor
|
I reran the |
maurycy
reviewed
Oct 15, 2026
maurycy
reviewed
Oct 15, 2026
maurycy
reviewed
Oct 15, 2026
Member
|
In Python 3.14, read_py_str() of Modules/_remote_debugging_module.c calls PyUnicode_FromStringAndSize(). I don't get how it works. It reads the UTF-8 representation of a string? What if the Unicode object has no UTF-8 representation? So it's unclear to me if Python 3.14 is also affected by the issue. |
vstinner
approved these changes
Oct 15, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Just some minor suggestions.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-Authored-By: Maurycy Pawłowski-Wieroński <maurycy@maurycy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of copying the remote bytes straight into a str, we now read them into a temp buffer and build the result with
PyUnicode_FromKindAndData, which validates the characters and picks the narrowest kind. Bad names raise an error so we end up with<unknown function>.