Skip to content

gh-157899: Skip test_readlink_is_marked_as_supports_fd on older macOS & iOS - #159403

Merged
vstinner merged 2 commits into
python:mainfrom
encukou:readlink-skip-old-macos-test
Oct 16, 2026
Merged

vstinner merged 2 commits into
python:mainfrom
encukou:readlink-skip-old-macos-test

Conversation

@encukou

@encukou encukou commented Oct 14, 2026 •

Copy link
Copy Markdown
Member
  • Generalize @requires_mac_ver logic to add @requires_ios_ver
  • Skip test_readlink_is_marked_as_supports_fd on lower Apple OS versions

- Generalize @requires_mac_ver logic to add @requires_ios_ver
- Skip test_readlink_is_marked_as_supports_fd on lower Apple OS versions
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Oct 14, 2026

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a nice thing to use a lazy import for platform in test.support.

    @support.requires_mac_ver(13, 0)
    @support.requires_ios_ver(16, 0)

these checks are consistent with Modules/posixmodule.c code:

#  define HAVE_FREADLINK_RUNTIME __builtin_available(macOS 13.0, iOS 16.0, *)

_requires_unix_version() could be updated to reuse _requires_apple_os_version() code, but that can be done in a separated PR if needed.

@vstinner
vstinner merged commit c7a1716 into python:main Oct 16, 2026
52 of 54 checks passed
@vstinner

Copy link
Copy Markdown
Member

I wanted to write a similar change before I saw your fix. You went further by making _requires_apple_os_version() more generic, nice!

@vstinner

Copy link
Copy Markdown
Member

Follow-up: #159523 "Factorize support._requires_unix_version() code".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants