Repository navigation
[3.15] gh-141276: Avoid compiling zipimport source in get_filename (GH-153799) - #159729
Merged
Merged
Conversation
…thonGH-153799) `zipimporter.get_filename()` compiled source modules just to work out the module's file name. `find_spec()` calls it through `spec_from_loader()`, so importing a source module from a ZIP archive compiled it twice and emitted every `SyntaxWarning` twice. `get_filename()` now returns before reading or compiling the source. As a result, a `SyntaxError` in a zipped source module is now raised by `exec_module()` rather than by `find_spec()` or `get_filename()`, and the source isn't compiled twice during import, which matches the filesystem-based loaders. (cherry picked from commit 230917f) Co-authored-by: Harjoth Khara <harjoth.khara@gmail.com>
miss-islington
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
October 19, 2026 18:23
Documentation build overview
141 files changed ·
|
itamaro
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zipimporter.get_filename()compiled source modules just to work out themodule's file name.
find_spec()calls it throughspec_from_loader(), soimporting a source module from a ZIP archive compiled it twice and emitted
every
SyntaxWarningtwice.get_filename()now returns before reading or compiling the source.As a result, a
SyntaxErrorin a zipped source module is now raised byexec_module()rather than byfind_spec()orget_filename(), andthe source isn't compiled twice during import, which matches
the filesystem-based loaders.
(cherry picked from commit 230917f)
Co-authored-by: Harjoth Khara harjoth.khara@gmail.com