Repository navigation
gh-159811: Raise OpenSSL errors in _hashlib.HASH after re-attaching the thread state - #159817
Merged
picnixz merged 1 commit intoOct 20, 2026
Merged
Conversation
…aching the thread state `_hashlib_HASH_hash()` set an exception when EVP_DigestUpdate() failed, but it is called inside a GIL-released region by `_hashlib.HASH.update()` and by the `_hashlib.HASH` constructor when the data exceeds HASHLIB_GIL_MINSIZE bytes. Setting the exception with the thread state detached crashed the interpreter instead of raising a ValueError. Only report the failure in `_hashlib_HASH_hash()` and set the exception in its callers once the thread state is re-attached. The OpenSSL error queue is per thread, so the exception message is unaffected.
picnixz
added
needs backport to 3.14
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @picnixz, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-159927 is a backport of this pull request to the 3.15 branch. |
|
GH-159937 is a backport of this pull request to the 3.14 branch. |
picnixz
added a commit
that referenced
this pull request
Oct 20, 2026
…taching the thread state (GH-159817) (#159937) When `EVP_DigestUpdate()` failed, `_hashlib_HASH_hash()` raised a Python exception, however, `_hashlib.HASH.update()` and the `_hashlib.HASH` constructor release the GIL before calling it when the data is larger than `HASHLIB_GIL_MINSIZE` bytes. `_hashlib_HASH_hash()` now only returns an error status and its callers raise the exception once they have re-attached the thread state. (cherry picked from commit 6fa2d64)
picnixz
added a commit
that referenced
this pull request
Oct 20, 2026
…taching the thread state (GH-159817) (#159927) gh-159811: Raise OpenSSL errors in `_hashlib.HASH` after re-attaching the thread state (GH-159817) When `EVP_DigestUpdate()` failed, `_hashlib_HASH_hash()` raised a Python exception, however, `_hashlib.HASH.update()` and the `_hashlib.HASH` constructor release the GIL before calling it when the data is larger than `HASHLIB_GIL_MINSIZE` bytes. `_hashlib_HASH_hash()` now only returns an error status and its callers raise the exception once they have re-attached the thread state. (cherry picked from commit 6fa2d64) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_hashlib_HASH_hash()set an exception whenEVP_DigestUpdate()failed, but it is called inside a GIL-released region by_hashlib.HASH.update()and by the_hashlib.HASHconstructor when the data exceedsHASHLIB_GIL_MINSIZEbytes. Setting the exception with the thread state detached crashes the interpreter instead of raising aValueError.Only report the failure in
_hashlib_HASH_hash()and set the exception in its callers once the thread state is re-attached. The OpenSSL error queue is per thread, so the exception message is unaffected.The
_hashlib.HMACcounterpart is handled in #159818 as it only affects 3.15 and later, whereas this one should be backported to 3.13 and 3.14 as well._hashlib: GIL may be released while attempting to set an exception #159811