Repository navigation
gh-153195: Allow splitting the PEG grammar into several files - #159917
Merged
Merged
Conversation
Add an @include meta to pegen: the rules of an included grammar file are appended to the including file's rules. The C generator emits the rules of each included file into a separate C file next to the main output. Use it to move the invalid_* rules from Grammar/python.gram into Grammar/invalid.gram, which generates Parser/parser_invalid.c.
lysnikolaou
requested review from
a team,
AA-Turner,
JacobCoffee,
StanFromIreland,
emmatyping,
ericsnowcurrently,
erlend-aasland,
ezio-melotti,
hugovk,
itamaro,
pablogsal and
webknjaz
as code owners
October 20, 2026 17:27
pablogsal
reviewed
Oct 20, 2026
hugovk
removed their request for review
October 20, 2026 21:14
pablogsal
approved these changes
Oct 23, 2026
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
I am going to benchmark to check if there is any speed regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
@includemeta to pegen: the rules of an included grammar file are appended to the including file's rules. The C generator emits the rules of each included file into a separate C file next to the main output.Use it to move the invalid_* rules from Grammar/python.gram into Grammar/invalid.gram, which generates Parser/parser_invalid.c.