Repository navigation
gh-160004: Fix build-details.json paths with --config-file-path - #160007
Merged
Merged
Conversation
make_paths_relative() first made base_prefix relative to the config file's directory and then made the other paths relative to that relative base_prefix, instead of the absolute one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
itamaro
added
build
brettcannon
approved these changes
Oct 21, 2026
Comment on lines
+3
to
+4
| and ``--config-file-path``. They are now relative to ``base_prefix``, as | ||
| required, instead of being computed from the already relative ``base_prefix``. |
Member
There was a problem hiding this comment.
I don't understand the phrasing of this final sentence. It reads so me like it's saying, "the paths are relative to base_prefix instead of being relative to base_prefix."
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
itamaro
enabled auto-merge (squash)
October 21, 2026 22:05
Contributor
|
Thanks @itamaro for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160143 is a backport of this pull request to the 3.15 branch. |
|
GH-160144 is a backport of this pull request to the 3.14 branch. |
itamaro
added a commit
that referenced
this pull request
Oct 22, 2026
…th` (GH-160007) (#160143) gh-160004: Fix build-details.json paths with `--config-file-path` (GH-160007) `make_paths_relative()` now keeps the absolute `base_prefix` for computing the other paths, and only the stored `base_prefix` is made relative to the config file's directory. This is the same fix python-build-standalone carries in `patch-python-relative-build-details.patch` (by @geofft). That patch also changes the Makefile to generate relative paths by default; this PR leaves the Makefile alone. (cherry picked from commit fc1a634) Co-authored-by: Itamar Oren <itamarost@gmail.com>
itamaro
added a commit
that referenced
this pull request
Oct 22, 2026
…th` (GH-160007) (#160144) gh-160004: Fix build-details.json paths with `--config-file-path` (GH-160007) `make_paths_relative()` now keeps the absolute `base_prefix` for computing the other paths, and only the stored `base_prefix` is made relative to the config file's directory. This is the same fix python-build-standalone carries in `patch-python-relative-build-details.patch` (by @geofft). That patch also changes the Makefile to generate relative paths by default; this PR leaves the Makefile alone. (cherry picked from commit fc1a634) Co-authored-by: Itamar Oren <itamarost@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_paths_relative()now keeps the absolutebase_prefixfor computing the other paths, and only the storedbase_prefixis made relative to the config file's directory. This is the same fix python-build-standalone carries inpatch-python-relative-build-details.patch(by @geofft). That patch also changes the Makefile to generate relative paths by default; this PR leaves the Makefile alone.Written with assistance from Claude Code Opus 5.5
generate-build-details.py --relative-paths --config-file-pathwrites wrong paths #160004