Repository navigation
Conversation
Signed-off-by: Casper Verbuyst <casperverbuyst@gmail.com>
Signed-off-by: Casper Verbuyst <casperverbuyst@gmail.com>
|
All commit authors signed the Contributor License Agreement. |
Signed-off-by: Casper Verbuyst <casperverbuyst@gmail.com>
NekoAsakura
requested changes
Oct 21, 2026
Co-authored-by: Neko Asakura <neko.asakura@outlook.com>
Signed-off-by: Casper Verbuyst <casperverbuyst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing
b'header'and then callingGzipFile.seek(16)can return6while the actual position is16. Code that uses the returned position to index records can therefore save incorrect offsets.Return the computed absolute target position without forcing another flush. Regression coverage checks absolute and relative seeks, small and large padding, a buffered write followed by
seek(0, SEEK_CUR), and decompressed contents.Validation: Windows x64 debug build of current main; test_gzip, test_zlib, and test_tarfile passed (960 cases reported, 23 skipped). Ruff 0.15.17 passed. The regression fails with the unchanged upstream gzip implementation and passes with the fix. The complete CPython suite and upstream CI have not been run.
Fixes #160071.