Repository navigation
gh-158660: Add PyListWriter C API
#160127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vstinner
wants to merge
9
commits into
python:main
Choose a base branch
from
vstinner:list_writer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+741
−17
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
79a2ae5
gh-158660: Add `PyListWriter` C API
vstinner d8be30d
Inline PyList_SET_ITEM()
vstinner 398c4b3
Remove redundant test_list_writer()
vstinner 3df6e01
Move _PyObject_GC_TRACK() to PyListWriter_Finish()
vstinner b0edd12
Merge branch 'main' into list_writer
vstinner f9d7145
Clarify PyListWriter_ExtendArray() doc
vstinner d096f46
Use list_new_prealloc() in PyListWriter_Create()
vstinner a8c24ee
Update PyListWriter_Create() comment
vstinner 31e5f1b
Add PyListWriter_ExtendArraySteal() function
vstinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
Misc/NEWS.d/next/C_API/2026-10-21-16-35-42.gh-issue-158660.KvixNp.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Add a new :ref:`PyListWriter <pylistwriter>` C API to create a :class:`list` | ||
| object. On Free Threading, it's more efficient than the ``PyList`` C API to | ||
| create a :class:`list`, because it can avoid the critical section on the | ||
| created list. Add functions: | ||
|
|
||
| * :c:func:`PyListWriter_Create` | ||
| * :c:func:`PyListWriter_Finish` | ||
| * :c:func:`PyListWriter_Discard` | ||
| * :c:func:`PyListWriter_Append` | ||
| * :c:func:`PyListWriter_AppendSteal` | ||
| * :c:func:`PyListWriter_Extend` | ||
| * :c:func:`PyListWriter_ExtendArray` | ||
| * :c:func:`PyListWriter_ExtendArraySteal` | ||
|
|
||
| Patch by Victor Stinner. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should say what happens to the refcounts of
itemson error (also on success: does it steal references?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It behaves as PyTuple_FromArray(): new references are created. I will reuse PyTuple_FromArray() phrasing: "copy references from array to the new tuple".