Repository navigation
gh-160206: Close connection explicitly in test_ssl - #160222
Merged
Merged
Conversation
test_https_client_non_tls_response_ignored() now uses a context manager for the server and always closes the connection to avoid ResourceWarning. Also add a timeout to SingleConnectionTestServerThread.__exit__() to not hang forever if something goes wrong.
vstinner
added
topic-SSL
needs backport to 3.14
Member
Author
|
!buildbot FreeBSD |
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit ed70e48 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F160222%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Member
Author
|
test_ssl passed on the 6 FreeBSD jobs. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160273 is a backport of this pull request to the 3.15 branch. |
|
GH-160274 is a backport of this pull request to the 3.14 branch. |
vstinner
added a commit
that referenced
this pull request
Oct 22, 2026
…#160273) gh-160206: Close connection explicitly in test_ssl (GH-160222) test_https_client_non_tls_response_ignored() now uses a context manager for the server and always closes the connection to avoid ResourceWarning. Also add a timeout to SingleConnectionTestServerThread.__exit__() to not hang forever if something goes wrong. (cherry picked from commit 9d42aee) Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
added a commit
that referenced
this pull request
Oct 22, 2026
…#160274) gh-160206: Close connection explicitly in test_ssl (GH-160222) test_https_client_non_tls_response_ignored() now uses a context manager for the server and always closes the connection to avoid ResourceWarning. Also add a timeout to SingleConnectionTestServerThread.__exit__() to not hang forever if something goes wrong. (cherry picked from commit 9d42aee) Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_https_client_non_tls_response_ignored() now uses a context manager for the server and always closes the connection to avoid ResourceWarning.
Also add a timeout to SingleConnectionTestServerThread.exit() to not hang forever if something goes wrong.